Refactor SLIP-132 key parsing to reduce code duplication #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gudnessuche
commented
Jan 3, 2025
Gudnessuche
commented
- Extracted common logic for SLIP-132 key parsing into a helper function decode_slip132_key.
- Implemented the decode_slip132_key function to handle both ---Xpub and Xpriv types, ensuring prefix validation and proper error handling.
- Updated FromSlip132 trait implementations for Xpub and Xpriv to utilize the new helper function.
- Ensured the new implementation is congruent with the original logic, maintaining functionality while reducing code duplication.
- Extracted common logic for SLIP-132 key parsing into a helper function decode_slip132_key. - Implemented the decode_slip132_key function to handle both ---Xpub and Xpriv types, ensuring prefix validation and proper error handling. - Updated FromSlip132 trait implementations for Xpub and Xpriv to utilize the new helper function. - Ensured the new implementation is congruent with the original logic, maintaining functionality while reducing code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.